diff options
author | Anna-Maria Behnsen <anna-maria@linutronix.de> | 2024-10-14 10:22:26 +0200 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2024-10-16 00:36:47 +0200 |
commit | 6279abf16a014474fba3de2e28b6ede871141cde (patch) | |
tree | 9cc95447cc3d512915552419e3de1864843b63b1 /kernel/time/sleep_timeout.c | |
parent | mm/damon/core: Use generic upper bound recommondation for usleep_range() (diff) | |
download | linux-6279abf16a014474fba3de2e28b6ede871141cde.tar.xz linux-6279abf16a014474fba3de2e28b6ede871141cde.zip |
timers: Add a warning to usleep_range_state() for wrong order of arguments
There is a warning in checkpatch script that triggers, when min and max
arguments of usleep_range_state() are in reverse order. This check does
only cover callsites which uses constants. Add this check into the code as
a WARN_ON_ONCE() to also cover callsites not using constants and fix the
mis-usage by resetting the delta to 0.
Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/all/20241014-devel-anna-maria-b4-timers-flseep-v3-9-dc8b907cb62f@linutronix.de
Diffstat (limited to 'kernel/time/sleep_timeout.c')
-rw-r--r-- | kernel/time/sleep_timeout.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/time/sleep_timeout.c b/kernel/time/sleep_timeout.c index f3f246e4c8d1..3054e5232d20 100644 --- a/kernel/time/sleep_timeout.c +++ b/kernel/time/sleep_timeout.c @@ -364,6 +364,9 @@ void __sched usleep_range_state(unsigned long min, unsigned long max, unsigned i ktime_t exp = ktime_add_us(ktime_get(), min); u64 delta = (u64)(max - min) * NSEC_PER_USEC; + if (WARN_ON_ONCE(max < min)) + delta = 0; + for (;;) { __set_current_state(state); /* Do not return before the requested sleep time has elapsed */ |