diff options
| author | Puranjay Mohan <puranjay@kernel.org> | 2025-01-15 11:36:47 +0100 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2025-01-15 22:44:08 +0100 |
| commit | 87c544108b612512b254c8f79aa5c0a8546e2cc4 (patch) | |
| tree | e7f8ed4f6e765df7e5cfdc1fe5814852207a32a3 /kernel | |
| parent | selftests/bpf: Fix test_xdp_adjust_tail_grow2 selftest on powerpc (diff) | |
| download | linux-87c544108b612512b254c8f79aa5c0a8546e2cc4.tar.xz linux-87c544108b612512b254c8f79aa5c0a8546e2cc4.zip | |
bpf: Send signals asynchronously if !preemptible
BPF programs can execute in all kinds of contexts and when a program
running in a non-preemptible context uses the bpf_send_signal() kfunc,
it will cause issues because this kfunc can sleep.
Change `irqs_disabled()` to `!preemptible()`.
Reported-by: syzbot+97da3d7e0112d59971de@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/67486b09.050a0220.253251.0084.GAE@google.com/
Fixes: 1bc7896e9ef4 ("bpf: Fix deadlock with rq_lock in bpf_send_signal()")
Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20250115103647.38487-1-puranjay@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/trace/bpf_trace.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index fc657c0eeb3e..71c1c02ca7a3 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -842,7 +842,7 @@ static int bpf_send_signal_common(u32 sig, enum pid_type type, struct task_struc if (unlikely(is_global_init(task))) return -EPERM; - if (irqs_disabled()) { + if (!preemptible()) { /* Do an early check on signal validity. Otherwise, * the error is lost in deferred irq_work. */ |