summaryrefslogtreecommitdiffstats
path: root/lib/maple_tree.c
diff options
context:
space:
mode:
authorWei Yang <richard.weiyang@gmail.com>2024-09-11 16:27:59 +0200
committerAndrew Morton <akpm@linux-foundation.org>2024-11-06 01:56:24 +0100
commit1c148069b240a3a65d1aee90c9d5c6997a747a7d (patch)
treecea7f11ce2b8b521646e45889bf1c7420a06d2b0 /lib/maple_tree.c
parentmaple_tree: i is always less than or equal to mas_end (diff)
downloadlinux-1c148069b240a3a65d1aee90c9d5c6997a747a7d.tar.xz
linux-1c148069b240a3a65d1aee90c9d5c6997a747a7d.zip
maple_tree: goto complete directly on a pivot of 0
When we break the loop after assigning a pivot, the index i/j is not changed. Then the following code assign pivot, which means we do the assignment with same i/j by mas_safe_pivot. Since the loop condition is (i < piv_end), from which we can get i is less than mt_pivots[mt]. It implies mas_safe_pivot() return pivot[i] which is the same value we get in loop. Now we can conclude it does a redundant assignment on a pivot of 0. Let's just go to complete to avoid it. Link: https://lkml.kernel.org/r/20240911142759.20989-3-richard.weiyang@gmail.com Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'lib/maple_tree.c')
-rw-r--r--lib/maple_tree.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 55958cbcc3fa..de883bfb97ef 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -1943,7 +1943,7 @@ static inline void mas_mab_cp(struct ma_state *mas, unsigned char mas_start,
for (; i < piv_end; i++, j++) {
b_node->pivot[j] = pivots[i];
if (unlikely(!b_node->pivot[j]))
- break;
+ goto complete;
if (unlikely(mas->max == b_node->pivot[j]))
goto complete;