diff options
| author | Duoming Zhou <duoming@zju.edu.cn> | 2024-05-30 07:17:33 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-06-02 00:49:42 +0200 |
| commit | 166fcf86cd34e15c7f383eda4642d7a212393008 (patch) | |
| tree | 535def0317ccf217ccbd6564692f160e0272a692 /net/ax25 | |
| parent | ax25: Fix refcount imbalance on inbound connections (diff) | |
| download | linux-166fcf86cd34e15c7f383eda4642d7a212393008.tar.xz linux-166fcf86cd34e15c7f383eda4642d7a212393008.zip | |
ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()
The object "ax25_dev" is managed by reference counting. Thus it should
not be directly released by kfree(), replace with ax25_dev_put().
Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240530051733.11416-1-duoming@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ax25')
| -rw-r--r-- | net/ax25/ax25_dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ax25/ax25_dev.c b/net/ax25/ax25_dev.c index 742d7c68e7e7..9efd6690b344 100644 --- a/net/ax25/ax25_dev.c +++ b/net/ax25/ax25_dev.c @@ -196,7 +196,7 @@ void __exit ax25_dev_free(void) list_for_each_entry_safe(s, n, &ax25_dev_list, list) { netdev_put(s->dev, &s->dev_tracker); list_del(&s->list); - kfree(s); + ax25_dev_put(s); } spin_unlock_bh(&ax25_dev_lock); } |