diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2020-08-26 21:40:06 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-08-27 01:16:39 +0200 |
| commit | 96e97bc07e90f175a8980a22827faf702ca4cb30 (patch) | |
| tree | 12b95b421bf2f7c68f77c5615c3857e9ceef0d63 /net/sctp | |
| parent | ipv4: Silence suspicious RCU usage warning (diff) | |
| download | linux-96e97bc07e90f175a8980a22827faf702ca4cb30.tar.xz linux-96e97bc07e90f175a8980a22827faf702ca4cb30.zip | |
net: disable netpoll on fresh napis
napi_disable() makes sure to set the NAPI_STATE_NPSVC bit to prevent
netpoll from accessing rings before init is complete. However, the
same is not done for fresh napi instances in netif_napi_add(),
even though we expect NAPI instances to be added as disabled.
This causes crashes during driver reconfiguration (enabling XDP,
changing the channel count) - if there is any printk() after
netif_napi_add() but before napi_enable().
To ensure memory ordering is correct we need to use RCU accessors.
Reported-by: Rob Sherwood <rsher@fb.com>
Fixes: 2d8bff12699a ("netpoll: Close race condition between poll_one_napi and napi_disable")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
0 files changed, 0 insertions, 0 deletions