diff options
| author | Takashi Iwai <tiwai@suse.de> | 2021-06-08 16:04:35 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2021-06-09 17:29:35 +0200 |
| commit | 10dc8ad5ffe8350d71e244b27900a1939d255fe7 (patch) | |
| tree | dbe91dbd35aa7cdc919278083b5fa79b3af047fd /sound/isa/sb/emu8000_patch.c | |
| parent | ALSA: usb-audio: scarlett2: Read mux at init time (diff) | |
| download | linux-10dc8ad5ffe8350d71e244b27900a1939d255fe7.tar.xz linux-10dc8ad5ffe8350d71e244b27900a1939d255fe7.zip | |
ALSA: sb: Fix assignment in if condition
A lot of code for SB drivers is in a legacy style with assignment in
if condition. This also made harder to catch some bugs (e.g. the
commit 1c98f574403d "ALSA: emu8000: Fix a use after free in
snd_emu8000_create_mixer").
This patch fixes the coding style. All are rather simple conversions
and there should be no functional changes.
(The changes in snd_emu8000_new() for hw->res_port1, 2 and 3 are
slightly different from the older ones, but this shouldn't matter
much in practice.)
Link: https://lore.kernel.org/r/20210608140540.17885-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa/sb/emu8000_patch.c')
| -rw-r--r-- | sound/isa/sb/emu8000_patch.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/isa/sb/emu8000_patch.c b/sound/isa/sb/emu8000_patch.c index 0cb94cafb4c9..8c1e7f2bfc34 100644 --- a/sound/isa/sb/emu8000_patch.c +++ b/sound/isa/sb/emu8000_patch.c @@ -191,7 +191,8 @@ snd_emu8000_sample_new(struct snd_emux *rec, struct snd_sf_sample *sp, sp->v.truesize = truesize * 2; /* in bytes */ snd_emux_terminate_all(emu->emu); - if ((rc = snd_emu8000_open_dma(emu, EMU8000_RAM_WRITE)) != 0) + rc = snd_emu8000_open_dma(emu, EMU8000_RAM_WRITE); + if (rc) return rc; /* Set the address to start writing at */ |