diff options
| author | Takashi Iwai <tiwai@suse.de> | 2024-12-30 12:40:22 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2024-12-30 12:40:53 +0100 |
| commit | abbff41b6932cde359589fd51f4024b7c85f366b (patch) | |
| tree | 6786f8817870151a4f14d4abe704f96a569afc54 /sound | |
| parent | ALSA: seq: oss: Fix races at processing SysEx messages (diff) | |
| download | linux-abbff41b6932cde359589fd51f4024b7c85f366b.tar.xz linux-abbff41b6932cde359589fd51f4024b7c85f366b.zip | |
Revert "ALSA: ump: Don't enumeration invalid groups for legacy rawmidi"
This reverts commit c2d188e137e77294323132a760a4608321a36a70.
Although it's fine to filter the invalid UMP groups at the first probe
time, this will become a problem when UMP groups are updated and
(re-)activated. Then there is no way to re-add the substreams
properly for the legacy rawmidi, and the new active groups will be
still invisible.
So let's revert the change. This will move back to showing the full
16 groups, but it's better than forever lost.
Link: https://patch.msgid.link/20241230114023.3787-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/core/ump.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/ump.c b/sound/core/ump.c index fe4d39ae1159..9198bff4768c 100644 --- a/sound/core/ump.c +++ b/sound/core/ump.c @@ -1244,7 +1244,7 @@ static int fill_legacy_mapping(struct snd_ump_endpoint *ump) num = 0; for (i = 0; i < SNDRV_UMP_MAX_GROUPS; i++) - if ((group_maps & (1U << i)) && ump->groups[i].valid) + if (group_maps & (1U << i)) ump->legacy_mapping[num++] = i; return num; |