summaryrefslogtreecommitdiffstats
path: root/Create.c
diff options
context:
space:
mode:
authorMariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>2022-01-20 13:18:33 +0100
committerJes Sorensen <jsorensen@fb.com>2022-04-05 03:29:43 +0200
commit5f21d67472ad08c1e96b4385254adba79aa1c467 (patch)
tree10144774aa470f040ff41e750eab055a94e3c137 /Create.c
parentCreate, Build: use default_layout() (diff)
downloadmdadm-5f21d67472ad08c1e96b4385254adba79aa1c467.tar.xz
mdadm-5f21d67472ad08c1e96b4385254adba79aa1c467.zip
mdadm: add map_num_s()
map_num() returns NULL if key is not defined. This patch adds alternative, non NULL version for cases where NULL is not expected. There are many printf() calls where map_num() is called on variable without NULL verification. It works, even if NULL is passed because gcc is able to ignore NULL argument quietly but the behavior is undefined. For safety reasons such usages will use map_num_s() now. It is a potential point of regression. Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Diffstat (limited to 'Create.c')
-rw-r--r--Create.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/Create.c b/Create.c
index 9ea19de0..c84c1ac8 100644
--- a/Create.c
+++ b/Create.c
@@ -83,7 +83,7 @@ int default_layout(struct supertype *st, int level, int verbose)
if (layout_map) {
layout = map_name(layout_map, "default");
- layout_name = map_num(layout_map, layout);
+ layout_name = map_num_s(layout_map, layout);
}
if (layout_name && verbose > 0)
pr_err("layout defaults to %s\n", layout_name);