summaryrefslogtreecommitdiffstats
path: root/mapfile.c
diff options
context:
space:
mode:
authorMike Lovell <mlovell@bluehost.com>2016-05-18 20:23:13 +0200
committerJes Sorensen <Jes.Sorensen@redhat.com>2016-06-03 21:35:26 +0200
commit13db17bd1fcd68b5e5618fcd051ff4137f1ea413 (patch)
treefbba6f912d4251402a4a5ddd63d1fca678561ed4 /mapfile.c
parentIMSM: retry reading sync_completed during reshape (diff)
downloadmdadm-13db17bd1fcd68b5e5618fcd051ff4137f1ea413.tar.xz
mdadm-13db17bd1fcd68b5e5618fcd051ff4137f1ea413.zip
Use dev_t for devnm2devid and devid2devnm
Commit 4dd2df0966ec added a trip through makedev(), major(), and minor() for device major and minor numbers. This would cause mdadm to fail in operating on a device with a minor number bigger than (2^19)-1 due to it changing from dev_t to a signed int and back. Where this was found as a problem was when a array was created with a device specified as a name like /dev/md/raidname and there were already 128 arrays on the system. In this case, mdadm would chose 1048575 ((2^20)-1) for the array and minor number. This would cause the major and minor number to become negative when generated from devnm2devid() and passed to major() and minor() in open_dev_excl(). open_dev_excl() would then call dev_open() which would detect the negative minor number and call open() on the *char containing the major:minor pair which isn't a valid file. Signed-off-by: Mike Lovell <mlovell@bluehost.com> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Diffstat (limited to 'mapfile.c')
-rw-r--r--mapfile.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/mapfile.c b/mapfile.c
index 243ded18..c89d403f 100644
--- a/mapfile.c
+++ b/mapfile.c
@@ -374,7 +374,7 @@ void RebuildMap(void)
char dn[30];
int dfd;
int ok;
- int devid;
+ dev_t devid;
struct supertype *st;
char *subarray = NULL;
char *path;