diff options
| author | Jes Sorensen <jsorensen@fb.com> | 2017-05-03 20:25:57 +0200 |
|---|---|---|
| committer | Jes Sorensen <jsorensen@fb.com> | 2017-05-03 22:15:16 +0200 |
| commit | 9db2ab4e9b1ad79b9364b6e03bdd675716a688a5 (patch) | |
| tree | 88417eb67da0146a151e94a9efebd38cdf0da6a2 /mdopen.c | |
| parent | change back 0644 permission for Grow.c (diff) | |
| download | mdadm-9db2ab4e9b1ad79b9364b6e03bdd675716a688a5.tar.xz mdadm-9db2ab4e9b1ad79b9364b6e03bdd675716a688a5.zip | |
util: md_array_valid(): Introduce md_array_valid() helper
Using md_get_array_info() to determine if an array is valid is broken
during creation, since the ioctl() returns -ENODEV if the device is
valid but not active.
Where did I leave my stash of brown paper bags?
Fixes: ("40b054e mdopen/open_mddev: Use md_get_array_info() to determine valid array")
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Diffstat (limited to 'mdopen.c')
| -rw-r--r-- | mdopen.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -442,7 +442,6 @@ int create_mddev(char *dev, char *name, int autof, int trustworthy, */ int open_mddev(char *dev, int report_errors) { - struct mdu_array_info_s array; int mdfd = open(dev, O_RDONLY); if (mdfd < 0) { @@ -452,7 +451,7 @@ int open_mddev(char *dev, int report_errors) return -1; } - if (md_get_array_info(mdfd, &array) != 0) { + if (md_array_valid(mdfd) == 0) { close(mdfd); if (report_errors) pr_err("%s does not appear to be an md device\n", dev); |