diff options
| author | NeilBrown <neilb@suse.com> | 2017-09-25 07:52:19 +0200 |
|---|---|---|
| committer | Jes Sorensen <jsorensen@fb.com> | 2017-09-27 23:30:27 +0200 |
| commit | fdbf7aaa19564520055971724b70ae1652e35788 (patch) | |
| tree | 579faf06095085057ee4c7c1a2ed5244552d09bd /mdopen.c | |
| parent | mdadm/test: add new testcase for testing readonly/readwrite (diff) | |
| download | mdadm-fdbf7aaa19564520055971724b70ae1652e35788.tar.xz mdadm-fdbf7aaa19564520055971724b70ae1652e35788.zip | |
mdopen: call "modprobe md_mod" if it might be needed.
Creating an array by opening a block-device with major number of 9
will transparently load the md module if needed.
Creating an array by opening
/sys/module/md_mod/parameters/new_array
and writing to it won't, it will just fail if md_mod isn't loaded.
So when opening that file fails with ENOENT, run "modprobe md_mod" and
try again.
This fixes a bug whereby if you have "CREATE names=yes" in mdadm.conf,
and the md modules isn't loaded, then creating or assembling an
array will not honor the "names=yes" configuration.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Diffstat (limited to 'mdopen.c')
| -rw-r--r-- | mdopen.c | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -312,6 +312,10 @@ int create_mddev(char *dev, char *name, int autof, int trustworthy, if (block_udev) udev_block(devnm); fd = open("/sys/module/md_mod/parameters/new_array", O_WRONLY); + if (fd < 0 && errno == ENOENT) { + system("modprobe md_mod"); + fd = open("/sys/module/md_mod/parameters/new_array", O_WRONLY); + } if (fd >= 0) { n = write(fd, devnm, strlen(devnm)); close(fd); |