diff options
| author | dtucker@openbsd.org <dtucker@openbsd.org> | 2017-12-06 00:59:47 +0100 |
|---|---|---|
| committer | Darren Tucker <dtucker@zip.com.au> | 2017-12-07 01:49:00 +0100 |
| commit | 609d96b3d58475a15b2eb6b3d463f2c5d8e510c0 (patch) | |
| tree | be75a3c395010d0ccf6e5c07e46e4e826203a221 /servconf.c | |
| parent | upstream commit (diff) | |
| download | openssh-609d96b3d58475a15b2eb6b3d463f2c5d8e510c0.tar.xz openssh-609d96b3d58475a15b2eb6b3d463f2c5d8e510c0.zip | |
upstream commit
Replace atoi and strtol conversions for integer arguments
to config keywords with a checking wrapper around strtonum. This will
prevent and flag invalid and negative arguments to these keywords. ok djm@
OpenBSD-Commit-ID: 99ae3981f3d608a219ccb8d2fff635ae52c17998
Diffstat (limited to 'servconf.c')
| -rw-r--r-- | servconf.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/servconf.c b/servconf.c index a9d727fdb..ff94bbd6b 100644 --- a/servconf.c +++ b/servconf.c @@ -1,5 +1,5 @@ -/* $OpenBSD: servconf.c,v 1.321 2017/12/05 23:56:07 dtucker Exp $ */ +/* $OpenBSD: servconf.c,v 1.322 2017/12/05 23:59:47 dtucker Exp $ */ /* * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland * All rights reserved @@ -1152,6 +1152,7 @@ process_server_config_line(ServerOptions *options, char *line, size_t len; long long val64; const struct multistate *multistate_ptr; + const char *errstr; /* Strip trailing whitespace. Allow \f (form feed) at EOL only */ if ((len = strlen(line)) == 0) @@ -1441,10 +1442,9 @@ process_server_config_line(ServerOptions *options, char *line, intptr = &options->x11_display_offset; parse_int: arg = strdelim(&cp); - if (!arg || *arg == '\0') - fatal("%s line %d: missing integer value.", - filename, linenum); - value = atoi(arg); + if ((errstr = atoi_err(arg, &value)) != NULL) + fatal("%s line %d: integer value %s.", + filename, linenum, errstr); if (*activep && *intptr == -1) *intptr = value; break; |