diff options
author | Richard Levitte <levitte@openssl.org> | 2019-02-14 09:25:40 +0100 |
---|---|---|
committer | Richard Levitte <levitte@openssl.org> | 2019-02-14 09:40:28 +0100 |
commit | f11ffa505f8a9345145a26a05bf77b012b6941bd (patch) | |
tree | acfc09812cd54bd463168b5e81839849ad4bbc16 | |
parent | Sparse array iterators include index position. (diff) | |
download | openssl-f11ffa505f8a9345145a26a05bf77b012b6941bd.tar.xz openssl-f11ffa505f8a9345145a26a05bf77b012b6941bd.zip |
Configure: stop forcing use of DEFINE macros in headers
There are times when one might want to use something like
DEFINE_STACK_OF in a .c file, because it defines a stack for a type
defined in that .c file. Unfortunately, when configuring with
`--strict-warnings`, clang aggressively warn about unused functions in
such cases, which forces the use of such DEFINE macros to header
files.
We therefore disable this warning from the `--strict-warnings`
definition for clang.
(note for the curious: `-Wunused-function` is enabled via `-Wall`)
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/8234)
-rwxr-xr-x | Configure | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -145,6 +145,8 @@ my $gcc_devteam_warn = "-DDEBUG_UNUSED" # -Wlanguage-extension-token -- no, we use asm() # -Wunused-macros -- no, too tricky for BN and _XOPEN_SOURCE etc # -Wextended-offsetof -- no, needed in CMS ASN1 code +# -Wunused-function -- no, it forces header use of safestack et al +# DEFINE macros my $clang_devteam_warn = "" . " -Wswitch-default" . " -Wno-parentheses-equality" @@ -154,6 +156,7 @@ my $clang_devteam_warn = "" . " -Wincompatible-pointer-types-discards-qualifiers" . " -Wmissing-variable-declarations" . " -Wno-unknown-warning-option" + . " -Wno-unused-function" ; # This adds backtrace information to the memory leak info. Is only used |