| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
also fix gather_subset warning and add some comments/notes
---------
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
| |
Flatten input is a list, not a dictionary.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a user doesn't exist and user module is used to create the user and the
homedir, adduser is called which parses HOME_MODE from /etc/login.defs, and when
not set calculates the mode from UMASK from the same file.
When a user already exists without homedir, and the user module is used to add a
home dir, it incorrectly ignores HOME_MODE, resulting in a world-readable home
dir when UMASK is not set. This is for example the case in Debian trixie and
later, and likely Ubuntu 25.04 and later.
Signed-off-by: Lee Garrett <lgarrett@rocketjump.eu>
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
|
| |
prompt now only errors if stdin is specifically triggered and not due to lack of other args
fixes #84489
---------
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
|
|
|
|
|
|
|
|
| |
* Added support for BSD-style digest file to test
checksum of downloaded file.
Fixes: #84476
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
| |
* Allows iptables chain creation with wait parameter
Fixes #84490
* Add the changelog fragment for 84490
|
|
|
|
|
|
|
|
| |
* update prompt for SSH key passphrase prompt
* introduce timeout in SSH key passphrase interaction
Fixes: #84484
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* fix[doc.py]: path will be undefined and a direct reference will throw an UnboundLocalError.
If none of the files in files exists, path will be undefined and a direct reference will throw an UnboundLocalError.
Repair function file parameter type annotation is inaccurate
* Update changelogs/fragments/fix-cli-doc-path_undefined.yaml
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
---------
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* with_dict better error message
* include type in error message
* changelog fragment
* Update lib/ansible/plugins/lookup/dict.py
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* specific wording
---------
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
variable (#84488)
Fixes:
Traceback (most recent call last):
File "/home/shertel/ansible/lib/ansible/plugins/vars/host_group_vars.py", line 139, in get_vars
FOUND[key] = found_files = loader.find_vars_files(opath, entity_name)
^^^
UnboundLocalError: cannot access local variable 'key' where it is not associated with a value
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/shertel/ansible/lib/ansible/plugins/vars/host_group_vars.py", line 151, in get_vars
raise AnsibleParserError(to_native(e))
ansible.errors.AnsibleParserError: cannot access local variable 'key' where it is not associated with a value
|
|
|
|
|
|
|
| |
Also remove redundant check from tqm
Now covers module output (set_fact/include_vars)
Includes play objects at any stage (tasks that error were not covered)
Added tests, moved them to role structure
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* constructed, let users know some limitations
reasons https://forum.ansible.com/t/debugging-constructed-inventory-constructing-group-from-values-of-host-variables/39443
* fix indent
* Update lib/ansible/plugins/doc_fragments/constructed.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* updated as per fb
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added docstrings to V2 methods in the CallbackBase Class (4 & 5 of 27)
* Made corrections as requested by webknjaz.
* Cleaned up whitespace issues.
* Corrections to customization note for review by webknjaz.
* Added rtype to return in docstrings.
* Simplified docstrings.
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
|
|
|
|
| |
- Document vixie cron compatible non-numeric values
- State which parameters cannot be used together with special_time
|
|
|
|
|
|
|
| |
gather_facts, fix network_os and smart logic and defaults
setup will be default for smart only if network_os is not set, now you get warnings and errors when missing a valid facts module for a network os
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
| |
* url lookup and uri module shares follow_redirects parameter,
moving it module_utils code.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
| |
* adding option for form-multipart data to switch multipart encoding from default base64 to 7or8bit encoding
Co-authored-by: davlas <david.lassig@bwi.de>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
|
| |
|
|
|
|
|
| |
* Make sure we are always using Lock from our multiprocessing context
* add clog frag
|
| |
|
|
|
|
|
| |
* copy, prevent internal options in task
fixes #84367
|
|
|
|
|
| |
* simplify redundancy with AnsibleModule set_*_if_different methods
* simplify copying a source directory to a dest directory without modifying behavior
|
|
|
| |
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
|
|
| |
* Allow user to control the trimming of blocks while templating
* Added tests
* Updated documentation and example
Fixes: #75962
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clamp zip timestamps to representible values when unpacking zip files on
platforms that use 32-bit time_t (e.g. Debian i386). This is a
non-issue in practice (in 2024), but should allow the test suite to pass
on Debian i386.
We use a round value of 2038-01-01 00:00:00 for simplicity, and to avoid
running into timezone offsets closer to the actual limit.
MR #81520 introduced sanity-checking tests that used dates not
representable with a 32-bit time_t.
|
|
|
|
|
|
|
|
|
| |
* ssh: Test reset_connection with templated ansible_ssh_executable
Add failing test to confirm subsequent fixes are necessary & sufficient.
* ssh: Fix reset_connection with templated ansible_ssh_executable
Signed-off-by: Alex Willmer <alex@moreati.org.uk>
|
|
|
|
|
|
|
| |
Open the double quotes at the beginning of the entire `failed_when` value.
Individual conditions work well, yet fail each time they are combined with a logic `or` (as per the example).
Double quoting the entire string solved the problem.
|
|
|
|
|
|
|
|
|
|
| |
This prevents "[WARNING]: Reset is not implemented for this connection" when
using wait_for_connection with localhost or other local hosts.
It's arguable (from a consistency/correctness perspective) that
`ansible.plugins.connection.local.Connection.reset()` should call
`Connection.close()`. I went for a no-op on the basis of "if it aint broke
don't fix it", and erred on the side of keeping existing semantics. However
either option would be fine with me.
|
| |
|
|
|
|
|
| |
* Integration tests for lookup_config
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
| |
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
| |
* test coverage for virtual/sysctl.py
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
| |
For it to be a human readable description it can't be an int.
|
|
|
|
|
| |
Fixes: #84318
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
| |
|
|
|
|
|
| |
Added ansible_uptime_seconds fact for AIX
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed deprecated include_delegate_to param
* Remove deprecated include_delegate_to param from
get_vars API in manager.py
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Make ignore.txt
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
|
| |
Fedora 41 no longer has python3-rpm installed by default either,
so package_facts blows up on Fedora 41 hosts unless you make sure
python3-rpm is installed first. Not sure we can do a lot about
this besides extending this note.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
|
|
|
|
| |
* dnf5,apt: add auto_install_module_deps option
Fixes #84206
|
|
|
| |
Fixes #84334
|
|
|
| |
Fixes #84259
|
|
|
|
| |
to merge (#84303)
|
|
|
|
| |
Co-authored-by: flowerysong <junk+github@flowerysong.com>
|
|
|
| |
also ref each other in seealso as they will commonly be used toghether
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Deprecated libvirt_lxc_noseclabel config
* deprecate moved libvirt_lxc_noseclabel config
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Make CI green I
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
---------
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
|
|
|
|
|
|
| |
* package_facts fix empty packages on foreign mgr
return the first package manager that provides output
add tests with fake rpm on apt machines
|