| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Fixes https://tracker.ceph.com/issues/69554
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
|\
| |
| |
| |
| |
| |
| | |
ShwetaBhosale1/fix_issue_69070_only_bind_ports_on_network_parameter_spec_for_alertmanager
mgr/cephadm: Add only_bind_ports_on_network spec parameter for Alertmanager
Reviewed-by: Adam King <adking@redhat.com>
|
| |
| |
| |
| |
| | |
Fixes: https://tracker.ceph.com/issues/69070
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
|
|\ \
| | |
| | |
| | |
| | | |
mgr/cephadm: allow disabling rgw_run_sync_thread through spec
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is desirable for an RGW service that you don't want to
send multisite sync data so the RGW daemons can focus more
on handling IO. Note they may still receive mulsitie sync
data unless they are removed from the zone and zonegroup
replication endpoints
Signed-off-by: Adam King <adking@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes https://tracker.ceph.com/issues/69413
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Added gateway and discovery address maps to the service specification.
These maps store per-node service addresses. The address is first searched
in the map, then in the spec address configuration. If neither is defined,
the host IP is used as a fallback.
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes https://tracker.ceph.com/issues/69176
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes https://tracker.ceph.com/issues/69176
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes https://tracker.ceph.com/issues/69099
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
|\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
ShwetaBhosale1/fix_issue_68605_modify_structure_of_default_images
cephadm: Modify the structure of the default container images
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes: https://tracker.ceph.com/issues/68605?next_issue_id=68599
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
configuration
Fixes https://tracker.ceph.com/issues/69036
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
|\ \
| | |
| | |
| | |
| | | |
mgr/cephadm: sign generated RGW certs
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously the "generate_cert" field would just cause cephadm
to generate self-signed certificates. This was an issue when trying to sync
the secondary site in a multisite situation, resulting in
```
SL peer certificate or SSH remote key was not OK req_data->error_buf=SSL
certificate problem: self-signed certificate request failed: (2200) Unknown error 2200
```
This change makes it so the certificate are signed by cephadm's
root CA cert so that users may grab that cert via
"ceph orch cert-store get cert cephadm_root_ca_cert"
and set that as a trusted CA cert on their secondary cluster.
Additionally, we now generate a cert per RGW daemon so that
we can include the hostname/addr of the node we are deploying
the RGW daemon on in the cert.
Signed-off-by: Adam King <adking@redhat.com>
|
|\ \
| | |
| | |
| | |
| | | |
various python 3.12 fixes
Reviewed-by: Adam King <adking@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Match recent(ish) changes to CMakeLists.txt for src/pybind/mgr and
stop hard-coding a list of tox envs to run when testing is triggered
via cmake.
Instead, automatically reuse the defaults in tox.ini. This is good
because we recently changed those defaults and this change makes
'make check' run the same set of tests and checks again.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
The file is no longer used for anything.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Update the tox.ini environments that lint the sources by splitting the
old lint env into one that just runs flake8 and another that runs the
rstcheck tool. I strongly dislike envs that do more than one thing and
make it hard to check specific files.
Additionally, the main point of this change was to drop the old
`requirements-lint.txt` requirements file that specified an extremely
old version of flake8 that did not work correctly with python 3.12. The
flake8 of src/pybind/mgr was not pinned so we now match that behavior in
src/python-common, which is heavily used by the mgr modules.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Update some function typing from the old comment based style to the current
type annotations style. Not only does this modernize the code but it fixes
issues found by newer versions of flake8 that were flagging types only
referenced in type comments as unused imports.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Tell flake8 not to flag unused imports when those imports are part of an
old-style type comment. This was done rather than updating the type
annotations to the latest style because I am less familiar with this
file and there are many type comments.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix a string that should not be an f-string by removing the f-string
(f) prefix. Error found by newer python/flake8 version.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rename a single letter variable name that was flagged by flake8. The
unique name `lbl` was chosen as it was short and didn't conflict with
any existing uses of the variable `label` in this file.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Tell flake8 not to flag unused imports when those imports are part of an
old-style type comment. This was done rather than updating the type annotations
to the latest style because I am less familiar with this file and there are
many type comments.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Tell flake8 not to flag unused imports when those imports are part of an
old-style type comment. This was done rather than updating the type annotations
to the latest style because I am less familiar with this file and there are
many type comments.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Tell flake8 not to flag unused imports when those imports are part of an
old-style type comment. This was done rather than updating the type annotations
to the latest style because I am less familiar with this file and there are
many type comments.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Tell flake8 not to flag unused imports when those imports are part of an
old-style type comment. This was done rather than updating the type annotations
to the latest style because I am less familiar with this file and there are
many type comments.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
flake8 flagged unused imports in this file due to the use of old style
type comments. This file was easy to convert to new style annotations so
that was done.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix various errors found by running mypy with python 3.12 on the
python-common subtree. Uses a Protocol as a stand-in for actual file
system integration objects.
Part of an effort to get ceph tox environments passing on Python 3.12.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
depends on: https://github.com/ceph/ceph-nvmeof/pull/898
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
|
|/ /
| |
| |
| |
| |
| | |
Fixes https://tracker.ceph.com/issues/68967
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
|/
|
|
|
|
| |
To be shared between the binary and mgr module.
Signed-off-by: Adam King <adking@redhat.com>
|
|\
| |
| |
| |
| |
| |
| | |
Adding HA support for mgmt-gateway and oauth2-proxy services
Reviewed-by: Adam king <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
adding HA support for mgmt-gateway and ouath2-proxy. In addition, logic
is add to prevent unnecessary daemons restart during mgr failover.
Previously, without the management gateway, some daemons, such as
Prometheus, had an explicit dependency on the manager because we
needed to point to the active manager. With the management gateway,
this explicit dependency is no longer necessary, as it automatically
handles routing requests to the active manager.
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
configuration
Fixes https://tracker.ceph.com/issues/68542
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
|/
|
|
|
|
|
|
|
|
| |
This introduces a new `ceph orch device replace` command in order to
improve the user experience when it comes to replacing the underlying
device of an OSD.
Fixes: https://tracker.ceph.com/issues/68456
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
|
|\
| |
| |
| |
| | |
prepare mypy checking for newer python (3.12)
Reviewed-by: Adam King <adking@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
As distutils is removed from python 3.12 ceph can no longer use the
simple conversion function once located in that module. Add our own
trivial replacement function.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
|\ \
| | |
| | |
| | |
| | | |
mgr/cephadm: adding health check endpoint for mgmt-gateway
Reviewed-by: Adam King <adking@redhat.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
|
| |/
|/|
| |
| | |
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
|
|\ \
| |/
|/|
| |
| | |
mgr/rgwam: use realm/zonegroup/zone method arguments for period update
Reviewed-by: Adam King <adking@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
period update method currently uses default zonegroup/zone for period
update commit. This PR is to use realm/zg/zone provided in the arguments
for period update. Also make the realm default that is created using realm pull
if it is the only realm present
Fixes: https://tracker.ceph.com/issues/67897
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
|
|\ \
| | |
| | |
| | |
| | | |
mgr/cephadm: default to empty string nvmeof group name rather than requiring it
Reviewed-by: John Mulligan <jmulligan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit f6d552d7c777f1160545188dcffa6b685b05ca8a.
It was decided by the nvmeof team to stick with defaulting to
an empty string rather than forcing the users onto other
non-empty names when they upgrade
Signed-off-by: Adam King <adking@redhat.com>
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
mgr/cephadm: open ceph-exporter when firewalld is enabled
Reviewed-by: Adam King <adking@redhat.com>
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
ceph-exporter port was not opened properly during daemon deployment
forcing the user to open it manually. This change fixes the logic to
open the port automatically.
Fixes: https://tracker.ceph.com/issues/67975
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
|