diff options
| author | Davidlohr Bueso <dave@stgolabs.net> | 2024-11-15 18:00:32 +0100 |
|---|---|---|
| committer | Dave Jiang <dave.jiang@intel.com> | 2024-12-10 22:30:51 +0100 |
| commit | da4d8c83358163df9a4addaeba0ef8bcb03b22e8 (patch) | |
| tree | 9ab04fe636e8908aaf1b551530f5d5bdb29d46ae /drivers/cxl | |
| parent | Linux 6.13-rc2 (diff) | |
| download | linux-da4d8c83358163df9a4addaeba0ef8bcb03b22e8.tar.xz linux-da4d8c83358163df9a4addaeba0ef8bcb03b22e8.zip | |
cxl/pci: Fix potential bogus return value upon successful probing
If cxl_pci_ras_unmask() returns non-zero, cxl_pci_probe() will end up
returning that value, instead of zero.
Fixes: 248529edc86f ("cxl: add RAS status unmasking for CXL")
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/20241115170032.108445-1-dave@stgolabs.net
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Diffstat (limited to 'drivers/cxl')
| -rw-r--r-- | drivers/cxl/pci.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c index 0241d1d7133a..26ab06c9deff 100644 --- a/drivers/cxl/pci.c +++ b/drivers/cxl/pci.c @@ -1032,8 +1032,7 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) if (rc) return rc; - rc = cxl_pci_ras_unmask(pdev); - if (rc) + if (cxl_pci_ras_unmask(pdev)) dev_dbg(&pdev->dev, "No RAS reporting unmasked\n"); pci_save_state(pdev); |